[PATCH] D56406: Remove check for single use in ShrinkDemandedConstant

Stanislav Mekhanoshin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 8 09:59:45 PST 2019


rampitec updated this revision to Diff 180689.
rampitec retitled this revision from "Check for single use in cvt_f32_ubyte combine instead of ShrinkDemandedConstant" to "Remove check for single use in ShrinkDemandedConstant".
rampitec edited the summary of this revision.
rampitec added a comment.

Removed call to ShrinkDemandedConstant completely.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56406/new/

https://reviews.llvm.org/D56406

Files:
  lib/CodeGen/SelectionDAG/TargetLowering.cpp
  lib/Target/AMDGPU/SIISelLowering.cpp


Index: lib/Target/AMDGPU/SIISelLowering.cpp
===================================================================
--- lib/Target/AMDGPU/SIISelLowering.cpp
+++ lib/Target/AMDGPU/SIISelLowering.cpp
@@ -8586,8 +8586,7 @@
   TargetLowering::TargetLoweringOpt TLO(DAG, !DCI.isBeforeLegalize(),
                                         !DCI.isBeforeLegalizeOps());
   const TargetLowering &TLI = DAG.getTargetLoweringInfo();
-  if (TLI.ShrinkDemandedConstant(Src, Demanded, TLO) ||
-      TLI.SimplifyDemandedBits(Src, Demanded, Known, TLO)) {
+  if (TLI.SimplifyDemandedBits(Src, Demanded, Known, TLO)) {
     DCI.CommitTargetLoweringOpt(TLO);
   }
 
Index: lib/CodeGen/SelectionDAG/TargetLowering.cpp
===================================================================
--- lib/CodeGen/SelectionDAG/TargetLowering.cpp
+++ lib/CodeGen/SelectionDAG/TargetLowering.cpp
@@ -350,9 +350,6 @@
   SDLoc DL(Op);
   unsigned Opcode = Op.getOpcode();
 
-  if (!Op.hasOneUse())
-    return false;
-
   // Do target-specific constant optimization.
   if (targetShrinkDemandedConstant(Op, Demanded, TLO))
     return TLO.New.getNode();


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D56406.180689.patch
Type: text/x-patch
Size: 1115 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190108/5f0ab0f0/attachment.bin>


More information about the llvm-commits mailing list