[PATCH] D56406: Check for single use in cvt_f32_ubyte combine instead of ShrinkDemandedConstant

[Stanislav Mekhanoshin via Phabricator via llvm-commits]

rampitec added a comment.

In D56406#1349488 <https://reviews.llvm.org/D56406#1349488>, @arsenm wrote:

> Something seems wrong here. How/why is this valid on AArch64 in some situation? A test is really needed for whatever this regression is


AArch64 does not call this function directly. The common code does required checks. In fact if you look at rare uses of it in targets they are guarded by single use check. Anyway, I do not have these testcases.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56406/new/

https://reviews.llvm.org/D56406