[PATCH] D56327: [PGO] Use SourceFileName rather module name in PGOFuncName

[Teresa Johnson via Phabricator via llvm-commits]

tejohnson added a comment.

In D56327#1350006 <https://reviews.llvm.org/D56327#1350006>, @kristina wrote:

> Differential Review is mostly for pre-commit review, add in "Differential Revision: https://reviews.llvm.org/DXXXXX" to the commit message and it will automatically link the commit and diff and close it. As an alternative you can do that manually, It seems bigger patch has already been committed in rL350579 <https://reviews.llvm.org/rL350579> (without review)


@xur  - something weird happened with your commits. The one mentioned by @kristina  above (r350579) was actually D56342 <https://reviews.llvm.org/D56342> ([llvm-profdata] add value-cutoff functionality to show command) which was reviewed, but somehow got the same title and commit message as this patch. Not sure if there is a way to go back and fix that in the commit log...if not I'd recommend reverting it and recommitting with the correct commit log and title.

Also, as @kristina  mentions, if your commit log contains a message like "Differential Revision: https://reviews.llvm.org/DXXXXX" it would link to the patch on phab.

> and this was pending review rL350442 <https://reviews.llvm.org/rL350442>. I've linked those in but if you say it's been fixed in the committed version and this is a followup, can you rebase the patch on the current trunk? For post-commit reviews Audit may be a better place if you need that.




CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56327/new/

https://reviews.llvm.org/D56327