[PATCH] D56327: [PGO] Use SourceFileName rather module name in PGOFuncName

[Rong Xu via llvm-commits]

I made a mistake when committing r350579 -- I saved the commit message into
a file but I used the wrong file. I will revert r350579 and recommit.

On Tue, Jan 8, 2019 at 1:48 PM Teresa Johnson via Phabricator <
reviews at reviews.llvm.org> wrote:

> tejohnson added a comment.
>
> In D56327#1350006 <https://reviews.llvm.org/D56327#1350006>, @kristina
> wrote:
>
> > Differential Review is mostly for pre-commit review, add in
> "Differential Revision: https://reviews.llvm.org/DXXXXX" to the commit
> message and it will automatically link the commit and diff and close it. As
> an alternative you can do that manually, It seems bigger patch has already
> been committed in rL350579 <https://reviews.llvm.org/rL350579> (without
> review)
>
>
> @xur  - something weird happened with your commits. The one mentioned by
> @kristina  above (r350579) was actually D56342 <
> https://reviews.llvm.org/D56342> ([llvm-profdata] add value-cutoff
> functionality to show command) which was reviewed, but somehow got the same
> title and commit message as this patch. Not sure if there is a way to go
> back and fix that in the commit log...if not I'd recommend reverting it and
> recommitting with the correct commit log and title.
>
> Also, as @kristina  mentions, if your commit log contains a message like
> "Differential Revision: https://reviews.llvm.org/DXXXXX" it would link to
> the patch on phab.
>
> > and this was pending review rL350442 <https://reviews.llvm.org/rL350442>.
> I've linked those in but if you say it's been fixed in the committed
> version and this is a followup, can you rebase the patch on the current
> trunk? For post-commit reviews Audit may be a better place if you need that.
>
>
>
>
> CHANGES SINCE LAST ACTION
>   https://reviews.llvm.org/D56327/new/
>
> https://reviews.llvm.org/D56327
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190108/a4088b20/attachment.html>