[PATCH] D56327: [PGO] Use SourceFileName rather module name in PGOFuncName

Kristina Brooks via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 8 11:07:15 PST 2019


kristina added a comment.

Differential Review is mostly for pre-commit review, add in "Differential Revision: https://reviews.llvm.org/DXXXXX" to the commit message and it will automatically link the commit and diff and close it. As an alternative you can do that manually, It seems bigger patch has already been committed in rL350579 <https://reviews.llvm.org/rL350579> (without review) and this was pending review rL350442 <https://reviews.llvm.org/rL350442>. I've linked those in but if you say it's been fixed in the committed version and this is a followup, can you rebase the patch on the current trunk? For post-commit reviews Audit may be a better place if you need that.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56327/new/

https://reviews.llvm.org/D56327





More information about the llvm-commits mailing list