[PATCH] D54369: [llvm-size][libobject] Add explicit "inTextSegment" methods similar to "isText" section methods to calculate size correctly.

[Jordan Rupprecht via Phabricator via llvm-commits]

rupprecht marked 2 inline comments as done.
rupprecht added a comment.

Sorry, for not getting to this patch sooner, I dropped it due to vacation + some unexpected things... I'm still eager to get this patch in :)

In D54369#1293994 <https://reviews.llvm.org/D54369#1293994>, @echristo wrote:

> I think this is the right direction, couple comment:
>
> - More detail in the comments for the *Segment methods. Maybe something elaborating about link/execution time or something else? Examples as well :)


Expanded a bit, I can add more if this isn't enough

> - While it's fairly obvious it'll work, a couple of sections with the right flags but not named the standard thing would be good for the test. .text.unlikely and .data1 maybe?

Done, added a couple examples both ways (named .text.* but not actually text, and named .something_random but is actually data)

(Addressed Ray's comments too)


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54369/new/

https://reviews.llvm.org/D54369