[PATCH] D54369: [llvm-size][libobject] Add explicit "inTextSegment" methods similar to "isText" section methods to calculate size correctly.

[Jordan Rupprecht via Phabricator via llvm-commits]

rupprecht updated this revision to Diff 177953.
rupprecht added a comment.

- Remove useless parens
- Rename inXXXSegment->isBerkeleyXXX
- Clarify segment comments
- Add test cases that ensure section flags are used instead of section names


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54369/new/

https://reviews.llvm.org/D54369

Files:
  include/llvm/Object/ELFObjectFile.h
  include/llvm/Object/ObjectFile.h
  lib/Object/ObjectFile.cpp
  test/tools/llvm-size/X86/elf-sizes.test
  test/tools/llvm-size/X86/ignore-sections.s
  tools/llvm-size/llvm-size.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D54369.177953.patch
Type: text/x-patch
Size: 7303 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20181212/4612717b/attachment-0001.bin>