[PATCH] D54369: [llvm-size][libobject] Add explicit "inTextSegment" methods similar to "isText" section methods to calculate size correctly.

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 12 15:55:10 PST 2018


MaskRay accepted this revision.
MaskRay added inline comments.
This revision is now accepted and ready to land.


================
Comment at: include/llvm/Object/ObjectFile.h:111
   bool isData() const;
+  /// Whether this section contains BSS initialized data.
   bool isBSS() const;
----------------
Typo here. initialized -> uninitialized

https://en.wikipedia.org/wiki/.bss "BSS reserves a block of uninitialized data"


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54369/new/

https://reviews.llvm.org/D54369





More information about the llvm-commits mailing list