[PATCH] D55542: [llvm-xray] Support for PIE

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 11 09:42:45 PST 2018


MaskRay added inline comments.


================
Comment at: llvm/lib/XRay/InstrumentationMap.cpp:97
+        // logic will need to be extended if other relocation types are
+        // ever being used.
+        auto AddendOrErr = object::ELFRelocationRef(Reloc).getAddend();
----------------
The code only works on x86_64 and ppc64le. So the relative relocations can just be enumerated here.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55542/new/

https://reviews.llvm.org/D55542





More information about the llvm-commits mailing list