[PATCH] D55542: [llvm-xray] Support for PIE

[Joerg Sonnenberger via Phabricator via llvm-commits]

joerg added inline comments.


================
Comment at: llvm/lib/XRay/InstrumentationMap.cpp:97
+        // logic will need to be extended if other relocation types are
+        // ever being used.
+        auto AddendOrErr = object::ELFRelocationRef(Reloc).getAddend();
----------------
MaskRay wrote:
> The code only works on x86_64 and ppc64le. So the relative relocations can just be enumerated here.
Please explicitly check for the relocation types you care about. They are not the only relocations you can find in a PIE binary, even with static  linking.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55542/new/

https://reviews.llvm.org/D55542