[PATCH] D55542: [llvm-xray] Support for PIE

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: llvm/lib/XRay/InstrumentationMap.cpp:90
+      // Skip sections that will never have any relocations.
+      if (Section.isBSS() || Section.isVirtual())
+        continue;
----------------
`Section.relocations()` applies on either `SHT_REL` or `SHT_RELA`. I think the code can be applied on just `SHT_RELA`.

`if (Section.isBSS() || Section.isVirtual())` is not necessary.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55542/new/

https://reviews.llvm.org/D55542