[PATCH] D55516: [GISel]: Add MachineIRBuilder support for passing in Flags while building instructions

Jessica Paquette via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 10 10:05:23 PST 2018


paquette added inline comments.


================
Comment at: lib/CodeGen/GlobalISel/MachineIRBuilder.cpp:797
+                                                 ArrayRef<SrcOp> SrcOps,
+                                                 Optional<unsigned> Flags) {
   switch (Opc) {
----------------
The other instances of this have

`Optional<unsigned> Flags = None`

Should this also have that?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55516/new/

https://reviews.llvm.org/D55516





More information about the llvm-commits mailing list