[PATCH] D55516: [GISel]: Add MachineIRBuilder support for passing in Flags while building instructions

[Aditya Nandakumar via Phabricator via llvm-commits]

aditya_nandakumar marked an inline comment as done.
aditya_nandakumar added inline comments.


================
Comment at: lib/CodeGen/GlobalISel/MachineIRBuilder.cpp:797
+                                                 ArrayRef<SrcOp> SrcOps,
+                                                 Optional<unsigned> Flags) {
   switch (Opc) {
----------------
paquette wrote:
> The other instances of this have
> 
> `Optional<unsigned> Flags = None`
> 
> Should this also have that?
I believe default parameter values are only allowed only once during the declaration (it's done in MachineIRBuilder.h) .


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55516/new/

https://reviews.llvm.org/D55516