[PATCH] D53706: [RecursionStackElimination]: Pass to eliminate recursions

[Martin Elshuber via Phabricator via llvm-commits]

marels marked 2 inline comments as done.
marels added inline comments.


================
Comment at: lib/Transforms/Scalar/MultiTailCallElimination.cpp:410
+  public:
+    RecursiveCall(CallInst *CI, size_t Index) : Index(Index), F(*CI->getParent()->getParent()), H(nullptr), CI(CI), Is() {}
+
----------------
lebedev.ri wrote:
> Please apply clang-format to this patch.
> 80 col width.
I will go through the source again fix these kind of things in the complete file. Thanks for the remainder.


================
Comment at: test/Transforms/MultiTailCallElimination/lit.local.cfg:1-2
+if not 'AArch64' in config.root.targets:
+    config.unsupported = True
----------------
lebedev.ri wrote:
> This looks wrong.
> This should then be in `test/Transforms/MultiTailCallElimination/AArch64/lit.local.cfg`
> The top-level `test/Transforms/MultiTailCallElimination/lit.local.cfg` should not be target-specific,
> or at least not specific to some one target.
I feel the same. I will fix this with the next commit.
However this is currently related to the Pipeline Integration issue. Which I currently do not like at all. Do you have an idea how to enable this pass specifically for AArch64. Clearly the pass has to run before TailCallElimination as TCE will pick of the last call and disable this pass completely.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D53706/new/

https://reviews.llvm.org/D53706