[PATCH] D53706: [RecursionStackElimination]: Pass to eliminate recursions

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri added inline comments.


================
Comment at: lib/Transforms/Scalar/MultiTailCallElimination.cpp:410
+  public:
+    RecursiveCall(CallInst *CI, size_t Index) : Index(Index), F(*CI->getParent()->getParent()), H(nullptr), CI(CI), Is() {}
+
----------------
Please apply clang-format to this patch.
80 col width.


================
Comment at: test/Transforms/MultiTailCallElimination/lit.local.cfg:1-2
+if not 'AArch64' in config.root.targets:
+    config.unsupported = True
----------------
This looks wrong.
This should then be in `test/Transforms/MultiTailCallElimination/AArch64/lit.local.cfg`
The top-level `test/Transforms/MultiTailCallElimination/lit.local.cfg` should not be target-specific,
or at least not specific to some one target.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D53706/new/

https://reviews.llvm.org/D53706