[PATCH] D53706: [RecursionStackElimination]: Pass to eliminate recursions

Tue Dec 4 07:49:16 PST 2018

lebedev.ri added inline comments.

================
Comment at: test/Transforms/MultiTailCallElimination/lit.local.cfg:1-2
+if not 'AArch64' in config.root.targets:
+    config.unsupported = True
----------------
marels wrote:
> lebedev.ri wrote:
> > This looks wrong.
> > This should then be in `test/Transforms/MultiTailCallElimination/AArch64/lit.local.cfg`
> > The top-level `test/Transforms/MultiTailCallElimination/lit.local.cfg` should not be target-specific,
> > or at least not specific to some one target.
> I feel the same. I will fix this with the next commit.
> However this is currently related to the Pipeline Integration issue. Which I currently do not like at all. Do you have an idea how to enable this pass specifically for AArch64. Clearly the pass has to run before TailCallElimination as TCE will pick of the last call and disable this pass completely.
Probably based on a target triple specified in the IR.
Though i can't tell how to reach that info from this pass..

But well, this is middle end, these passes generally shouldn't be //too// target arch specific.
Is this likely fundamentally wrong for non-aarch64?

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D53706/new/

https://reviews.llvm.org/D53706