[PATCH] D54953: [DWARFv5] Verify all-or-nothing constraint on DIFile source

[David Blaikie via Phabricator via llvm-commits]

dblaikie added a comment.

In D54953#1309829 <https://reviews.llvm.org/D54953#1309829>, @scott.linder wrote:

> Actually, after thinking about this I agree more with the approach of dropping or somehow warning/failing in the DWARF backend, rather than verifying at the IR level. Conceivably another DI backend which implements embedded source might not have the same restriction as DWARF, so restricting the IR doesn't seem right.


Yeah, I'd rather keep the restriction until we have a use case that merits removing it.

I'll leave the sign-off here to @aprantl or @JDevlieghere who have more familiarity/investment in the verifier.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54953/new/

https://reviews.llvm.org/D54953