[PATCH] D54953: [DWARFv5] Verify all-or-nothing constraint on DIFile source
Adrian Prantl via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Nov 28 14:50:49 PST 2018
aprantl added a comment.
Is this constraint per-DICompileUnit or per llvm::Module? If it is per DICompileUnit then this implementation is too strict.
================
Comment at: lib/IR/Verifier.cpp:1026
}
+ bool HasSource = !!N.getSource();
+ if (!HasSourceDebugInfo)
----------------
is there a less clever and more clear way to write this?
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D54953/new/
https://reviews.llvm.org/D54953
More information about the llvm-commits
mailing list