[PATCH] D54953: [DWARFv5] Verify all-or-nothing constraint on DIFile source

[Scott Linder via Phabricator via llvm-commits]

scott.linder added a comment.

Actually, after thinking about this I agree more with the approach of dropping or somehow warning/failing in the DWARF backend, rather than verifying at the IR level. Conceivably another DI backend which implements embedded source might not have the same restriction as DWARF, so restricting the IR doesn't seem right.

In the case of https://reviews.llvm.org/D53329 the dropping might be surprising, however, as the MD5 handling only seems to warn in the AsmParser.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54953/new/

https://reviews.llvm.org/D54953