[PATCH] D54946: [yaml2obj] [COFF] Subtract the image base for section virtual addresses

Martin Storsjö via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 27 10:26:33 PST 2018


mstorsjo added a comment.

In D54946#1309777 <https://reviews.llvm.org/D54946#1309777>, @ruiu wrote:

> LGTM
>
> This is perhaps my personal preference, but I think making it a relative address from ImageBase seems like a good idea, because by doing that we get smaller numbers that are easier to read.


So you mean that you'd prefer changing obj2yaml instead? Is there any specification on what the yaml format should be? Changing obj2yaml would make more sense as well, since then we'd write more exactly what the file contains, instead of the interpretation of it.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54946/new/

https://reviews.llvm.org/D54946





More information about the llvm-commits mailing list