[PATCH] D54946: [yaml2obj] [COFF] Subtract the image base for section virtual addresses
Rui Ueyama via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Nov 27 08:20:00 PST 2018
ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.
LGTM
This is perhaps my personal preference, but I think making it a relative address from ImageBase seems like a good idea, because by doing that we get smaller numbers that are easier to read.
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D54946/new/
https://reviews.llvm.org/D54946
More information about the llvm-commits
mailing list