[PATCH] D54946: [yaml2obj] [COFF] Subtract the image base for section virtual addresses

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added a comment.

Oh, I misunderstood this patch. Sorry for the confusion. My preference was just what I wrote in the previous comment, but that's not a strong preference or anything, and it also makes sense to make values in a YAML file the same as the ones in the actual file, so this patch is fine to me.

YAML object file is an LLVM thing, and I don't think there's a specification as to what value should be written to a YAML file, and I don't think we can mechanically define it. YAML object file resembles actual binary object file, but YAML object file is slightly more abstract (e.g. it doesn't contain section offsets in a file or does not really specify any concrete file layout).


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54946/new/

https://reviews.llvm.org/D54946