[PATCH] D54649: [FPEnv] Rough out constrained FCmp intrinsics

[Nicolai Hähnle via Phabricator via llvm-commits]

nhaehnle added inline comments.


================
Comment at: include/llvm/IR/Intrinsics.td:163
+  LLVMType ElTy = elty;
+}
 class LLVMPointerTo<int num> : LLVMMatchType<num>;
----------------
nhaehnle wrote:
> cameron.mcinally wrote:
> > This should probably be more strict. We could end up with something like <2 <2 x double>> as an argument. There's some C++ code later that should catch that case, but we could probably come up with a better class to extend here.
> Either way, it needs a comment that explains what it does :)
I should say that my first thought at the name was that it's about bit width, which it's not, so maybe the name could be improved as well? And the num parameter doesn't currently go anywhere, which means that this can't work. The class should instead derive from `LLVMMatchType<num>`.


Repository:
  rL LLVM

https://reviews.llvm.org/D54649