[PATCH] D54649: [FPEnv] Rough out constrained FCmp intrinsics
Nicolai Hähnle via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Nov 19 03:51:50 PST 2018
nhaehnle added inline comments.
================
Comment at: include/llvm/IR/Intrinsics.td:163
+ LLVMType ElTy = elty;
+}
class LLVMPointerTo<int num> : LLVMMatchType<num>;
----------------
cameron.mcinally wrote:
> This should probably be more strict. We could end up with something like <2 <2 x double>> as an argument. There's some C++ code later that should catch that case, but we could probably come up with a better class to extend here.
Either way, it needs a comment that explains what it does :)
Repository:
rL LLVM
https://reviews.llvm.org/D54649
More information about the llvm-commits
mailing list