[PATCH] D54649: [FPEnv] Rough out constrained FCmp intrinsics

[Ulrich Weigand via Phabricator via llvm-commits]

uweigand added a comment.

In general, I think going forward the back-ends should be explicitly aware of the STRICT_ FP nodes.  Anyway, that's the direction my proposed SystemZ patch takes: https://reviews.llvm.org/D45576

While the above patch currently only forwards Legal STRICT_ nodes to the back-end, it would only be logical to also forward Custom STRICT_ nodes, so that the target can handle them as necessary.

So I'm not sure why you're adding special code to handle Custom STRICT_ nodes in common code -- that seems to somewhat contradict the very notion of Custom.  I believe if the target does mark any STRICT_ node as Custom, it expects to handle those for itself.

(A different issue may be where a STRICT_ node is marked as Expand and therefore translated to a non-strict node -- but **that** non-strict node was already marked Custom by the target.  We may have to handle that case specially somehow, I'm not sure ...)


Repository:
  rL LLVM

https://reviews.llvm.org/D54649