[PATCH] D54614: [WebAssembly] Fix MCNullStreamer support
Sam Clegg via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Nov 16 14:49:04 PST 2018
sbc100 accepted this revision.
sbc100 added inline comments.
This revision is now accepted and ready to land.
================
Comment at: test/CodeGen/WebAssembly/null-streamer.ll:11
+define i32 @f(i8* %p) {
+ call void @llvm.wasm.throw(i32 0, i8* %p)
+ call void @g()
----------------
eush wrote:
> sbc100 wrote:
> > Can you simplify this test, drop the trow and remove the exception arguments from llc?
> Can I wonder why? A simpler test would only exercise changes in EmitFunctionBodyStart and wouldn't need any changes in EmitEndOfAsmFile.
Oh I see. I just found a it a little strange to have those options enabled, but I suppose it makes sense. Alternatively you could call alloca in order to trigger the use of __stack_pointer.
Also, if you want to be sure you excersise those parts maybe you would want to at a CHECK: for the .globaltype and/or .eventtype at the end?
Repository:
rL LLVM
https://reviews.llvm.org/D54614
More information about the llvm-commits
mailing list