[PATCH] D54614: [WebAssembly] Fix MCNullStreamer support

Eugene Sharygin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 16 14:17:06 PST 2018


eush added inline comments.


================
Comment at: test/CodeGen/WebAssembly/null-streamer.ll:11
+define i32 @f(i8* %p)  {
+  call void @llvm.wasm.throw(i32 0, i8* %p)
+  call void @g()
----------------
sbc100 wrote:
> Can you simplify this test, drop the trow and remove the exception arguments from llc?
Can I wonder why? A simpler test would only exercise changes in EmitFunctionBodyStart and wouldn't need any changes in EmitEndOfAsmFile.


Repository:
  rL LLVM

https://reviews.llvm.org/D54614





More information about the llvm-commits mailing list