[PATCH] D54614: [WebAssembly] Fix MCNullStreamer support

[Heejin Ahn via Phabricator via llvm-commits]

aheejin added a comment.

Thanks for doing this! By the way, every time we use `getTargetStreamer()`, are we required do this? I checked some other `*AsmPrinter.cpp` files for other targets and it seems they are not doing this, but they can run `-filetype=null` with no problem.



================
Comment at: test/CodeGen/WebAssembly/null-streamer.ll:11
+define i32 @f(i8* %p)  {
+  call void @llvm.wasm.throw(i32 0, i8* %p)
+  call void @g()
----------------
sbc100 wrote:
> eush wrote:
> > sbc100 wrote:
> > > Can you simplify this test, drop the trow and remove the exception arguments from llc?
> > Can I wonder why? A simpler test would only exercise changes in EmitFunctionBodyStart and wouldn't need any changes in EmitEndOfAsmFile.
> Oh I see.   I just found a it a little strange to have those options enabled, but I suppose it makes sense.  Alternatively you could call alloca in order to trigger the use of __stack_pointer.
> 
> Also, if you want to be sure you excersise those parts maybe you would want to at a CHECK: for the .globaltype and/or .eventtype at the end?
This is nullstreamer, so I guess it wouldn't print anything so we can't check.


Repository:
  rL LLVM

https://reviews.llvm.org/D54614