[PATCH] D54042: [AMDGPU] Extend the SI Load/Store optimizer to combine more things.

[Neil Henning via Phabricator via llvm-commits]

sheredom added inline comments.


================
Comment at: lib/Target/AMDGPU/SILoadStoreOptimizer.cpp:79
+enum InstClassEnum {
+  UNKNOWN,
+  DS_READ,
----------------
nhaehnle wrote:
> Why is this needed?
I use it for the cases where the intrinsic does not match any of the intrinsics that we can do optimizations on.


================
Comment at: lib/Target/AMDGPU/SILoadStoreOptimizer.cpp:83
+  S_BUFFER_LOAD_IMM,
+  BUFFER_LOAD_IDXEN,
+  BUFFER_LOAD_OFFEN,
----------------
nhaehnle wrote:
> Do those actually occur like this in practice?
Do you mean do I see idxen loads in workloads? Yup!


https://reviews.llvm.org/D54042