[PATCH] D53992: [DebugInfo] Correctly sink DBG_VALUEs in postra-machine-sink

[Adrian Prantl via Phabricator via llvm-commits]

aprantl added inline comments.


================
Comment at: lib/CodeGen/MachineSink.cpp:960
+  /// Track DBG_VALUEs of (unmodified) register units
+  std::multimap<unsigned, MachineInstr *> SeenDbgInstrs;
+
----------------
Would a (Small)DenseMap<SmallVector> be more efficient?


================
Comment at: lib/CodeGen/MachineSink.cpp:1129
+    // We potentially have to sink this DBG_VALUE if its operand is sunk, and
+    // it may not be anywhere near the register def
+    if (MI->isDebugValue()) {
----------------
Nitpick: Please always use full sentences in comments with a trailing `.`


Repository:
  rL LLVM

https://reviews.llvm.org/D53992