[PATCH] D53992: [DebugInfo] Correctly sink DBG_VALUEs in postra-machine-sink
Reid Kleckner via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Nov 1 13:54:08 PDT 2018
rnk added inline comments.
================
Comment at: lib/CodeGen/MachineSink.cpp:960
+ /// Track DBG_VALUEs of (unmodified) register units
+ std::multimap<unsigned, MachineInstr *> SeenDbgInstrs;
+
----------------
aprantl wrote:
> Would a (Small)DenseMap<SmallVector> be more efficient?
Peanut gallery: DenseMap of Small* things are usually not efficient. There is TinyPtrVector, though, which is optimized for this use case, so `DenseMap<unsigned, TinyPtrVector<MachineInstr*>>` is probably a good choice.
Repository:
rL LLVM
https://reviews.llvm.org/D53992
More information about the llvm-commits
mailing list