[PATCH] D53992: [DebugInfo] Correctly sink DBG_VALUEs in postra-machine-sink

[Paul Robinson via Phabricator via llvm-commits]

probinson added a comment.

Please review all comments to ensure proper punctuation.  There are a lot of missing full-stops.



================
Comment at: lib/CodeGen/MachineSink.cpp:741
+                        SmallVectorImpl<MachineInstr *> *DbgVals = nullptr) {
+  // If debug values provided, use those, otherwise collect
   SmallVector<MachineInstr *, 2> DbgValuesToSink;
----------------
Comment needs to finish the thought; or is it just missing a full-stop?


================
Comment at: lib/CodeGen/MachineSink.cpp:1182
+    for (auto &MO : MI->operands()) {
+      if (!MO.isReg() || !MO.isDef()) continue;
+      unsigned reg = MO.getReg();
----------------
Did clang-format-diff let you do this? Normally 'continue' would be on the next line.


Repository:
  rL LLVM

https://reviews.llvm.org/D53992