[PATCH] D53992: [DebugInfo] Correctly sink DBG_VALUEs in postra-machine-sink

[Paul Robinson via Phabricator via llvm-commits]

probinson added a comment.

Presumably this addresses the bad debugging experience for the sample from the PR; does it have any other good/bad effect on the Dexter corpus?



================
Comment at: test/CodeGen/X86/pr38952.mir:72
+  
+  ; TEST: the DBG_VALUE on ebx below is not sunk with the def of ebx in PR38952,
+  ; check that ebx sinks and the DBG_VALUE follows it.
----------------
The way this comment is written looks like an alternate CHECK line, except it isn't.  You can just say "Test that the DBG_VALUE ..." and avoid the potential confusion.


Repository:
  rL LLVM

https://reviews.llvm.org/D53992