[PATCH] D53534: [hot-cold-split] Name split functions with ".cold" suffix

[Sebastian Pop via Phabricator via llvm-commits]

sebpop added a comment.

The change looks good with some minor changes.  Thanks!



================
Comment at: lib/Transforms/IPO/HotColdSplitting.cpp:345
+                   /* AllowAlloca */ false,
+                   /* Suffix */ "cold" + std::to_string(Count));
 
----------------
Given the commit message: Pass in "cold."+Count
I think the above statement is missing the dot after cold:

  /* Suffix */ "cold." + std::to_string(Count));


================
Comment at: lib/Transforms/IPO/HotColdSplitting.cpp:424
         // Candidate for outlining. FIXME: Continue outlining.
-        return extractColdRegion(ValidColdRegion, DT, BFI, ORE);
+        return extractColdRegion(ValidColdRegion, DT, BFI, ORE, /* Count */ 1);
       }
----------------
I like this change, makes it very easy to get unique function names.



================
Comment at: test/Transforms/HotColdSplit/split-cold-2.ll:7
 
-; CHECK: remark: <unknown>:0:0: fun split cold code into fun_if.else
+; CHECK: remark: <unknown>:0:0: fun split cold code into fun.cold
 ; CHECK-LABEL: @fun
----------------
I was expecting to see an integer appended to "cold" like so "fun.cold.1"


Repository:
  rL LLVM

https://reviews.llvm.org/D53534