[PATCH] D53534: [hot-cold-split] Name split functions with ".cold" suffix

[Teresa Johnson via Phabricator via llvm-commits]

tejohnson added inline comments.


================
Comment at: lib/Transforms/IPO/HotColdSplitting.cpp:345
+                   /* AllowAlloca */ false,
+                   /* Suffix */ "cold" + std::to_string(Count));
 
----------------
sebpop wrote:
> Given the commit message: Pass in "cold."+Count
> I think the above statement is missing the dot after cold:
> 
>   /* Suffix */ "cold." + std::to_string(Count));
Indeed, this was missing the ".", fixed.


================
Comment at: test/Transforms/HotColdSplit/split-cold-2.ll:7
 
-; CHECK: remark: <unknown>:0:0: fun split cold code into fun_if.else
+; CHECK: remark: <unknown>:0:0: fun split cold code into fun.cold
 ; CHECK-LABEL: @fun
----------------
sebpop wrote:
> I was expecting to see an integer appended to "cold" like so "fun.cold.1"
Yep, it was passing because of the partial match working. I added the ".1" (which in fact would have caught the oversight you pointed out earlier in the code!).


Repository:
  rL LLVM

https://reviews.llvm.org/D53534