[PATCH] D53534: [hot-cold-split] Name split functions with ".cold" suffix

[Teresa Johnson via Phabricator via llvm-commits]

tejohnson updated this revision to Diff 170742.
tejohnson added a comment.
Herald added a subscriber: eraman.

1. Always use "." as the delimiter for the suffix instead of "_" to enable demangling
2. If the label is empty and no suffix passed in from client, use "extracted" after the "." (the demangler needs something after the "." to handle it correctly).
3. Pass in "cold."+Count from the hot cold splitting pass as the suffix, where Count is currently hardwired to 1 but after https://reviews.llvm.org/D53588 can be changed to be a monotonically increasing count of the functions split from a single function.

Unfortunately change 1) required many test changes.


Repository:
  rL LLVM

https://reviews.llvm.org/D53534

Files:
  include/llvm/Transforms/Utils/CodeExtractor.h
  lib/Transforms/IPO/HotColdSplitting.cpp
  lib/Transforms/Utils/CodeExtractor.cpp
  test/Transforms/BlockExtractor/extract-blocks.ll
  test/Transforms/CodeExtractor/ExtractedFnEntryCount.ll
  test/Transforms/CodeExtractor/PartialInlineAnd.ll
  test/Transforms/CodeExtractor/PartialInlineAndOr.ll
  test/Transforms/CodeExtractor/PartialInlineAttributes.ll
  test/Transforms/CodeExtractor/PartialInlineDebug.ll
  test/Transforms/CodeExtractor/PartialInlineEntryUpdate.ll
  test/Transforms/CodeExtractor/PartialInlineInvokeProducesOutVal.ll
  test/Transforms/CodeExtractor/PartialInlineLiveAcross.ll
  test/Transforms/CodeExtractor/PartialInlineNoLiveOut.ll
  test/Transforms/CodeExtractor/PartialInlineOr.ll
  test/Transforms/CodeExtractor/PartialInlineOrAnd.ll
  test/Transforms/CodeExtractor/PartialInlinePGOMultiRegion.ll
  test/Transforms/CodeExtractor/PartialInlinePGORegion.ll
  test/Transforms/CodeExtractor/PartialInlineVarArg.ll
  test/Transforms/CodeExtractor/PartialInlineVarArgsDebug.ll
  test/Transforms/CodeExtractor/SingleCondition.ll
  test/Transforms/CodeExtractor/X86/InheritTargetAttributes.ll
  test/Transforms/CodeExtractor/cost.ll
  test/Transforms/CodeExtractor/cost_meta.ll
  test/Transforms/CodeExtractor/inline_eh.ll
  test/Transforms/CodeExtractor/inline_eh_1.ll
  test/Transforms/CodeExtractor/live_shrink.ll
  test/Transforms/CodeExtractor/live_shrink_gep.ll
  test/Transforms/CodeExtractor/live_shrink_hoist.ll
  test/Transforms/CodeExtractor/live_shrink_multiple.ll
  test/Transforms/CodeExtractor/unreachable-block.ll
  test/Transforms/HotColdSplit/split-cold-2.ll
  test/Transforms/HotColdSplit/split-out-dbg-val-of-arg.ll
  test/tools/llvm-extract/extract-block.ll
  test/tools/llvm-extract/extract-multiple-blocks.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D53534.170742.patch
Type: text/x-patch
Size: 27637 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20181023/0bac2569/attachment-0001.bin>