[PATCH] D53291: add riscv32e to the llvm

Roger Ferrer Ibanez via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 15 08:34:28 PDT 2018


rogfer01 added inline comments.


================
Comment at: lib/Target/RISCV/RISCVISelLowering.cpp:42
 
+static bool isRVE = false;
+
----------------
I wonder if we can avoid this global variable and instead use `Subtarget.isEmbed()` where needed.

This will require passing a `const RISCVSubtarget&` to some functions (like `CC_RISCV`) but given that they are local to the file, I think that would be reasonable.


Repository:
  rL LLVM

https://reviews.llvm.org/D53291





More information about the llvm-commits mailing list