[PATCH] D52680: Add comments explaning variables in action table generation (NFC)
Kristina Brooks via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Oct 2 03:27:14 PDT 2018
kristina added a comment.
I don't think any of them are necessary, especially saying "usually 1" without any further explanation. They could be less ambiguous with an elaboration like "usually 1 unless ... etc", but all in all, I don't think they're helpful as they basically just repeat the variable names.
Repository:
rL LLVM
https://reviews.llvm.org/D52680
More information about the llvm-commits
mailing list