[PATCH] D52680: Add comments explaning variables in action table generation (NFC)

Heejin Ahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 1 15:35:30 PDT 2018


aheejin added a comment.

Yes.. I agree 'usually something' does not sound great. I added that because I thought it would be rare for those variables to have size other than 1 or 2 using LEB128 encoding, but I can remove it.
I also agree the meanings of `SizeTypeID` and `SizeActions` are easy to guess from their variable names, but to me the code was a bit confusing because there were also `SizeSiteActions` and `SizeAction` too. I think if we had these comments that would have saved me at least 10 mins I guess, so I added them. Do you think all of the comments here are very obvious and not necessary?


Repository:
  rL LLVM

https://reviews.llvm.org/D52680





More information about the llvm-commits mailing list