[PATCH] D52680: Add comments explaning variables in action table generation (NFC)

Kristina Brooks via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 2 03:33:19 PDT 2018


kristina added a comment.

If you really think it would help, I would suggest renaming that variable but still keep the name brief but more informative. That's a better solution that polluting it with comments, but I'd still lean towards not changing anything at all, since I don't think it's that confusing, and the developer policy generally leans against such changes unless they really vastly improve code clarity, which is not the case here from what I feel.


Repository:
  rL LLVM

https://reviews.llvm.org/D52680





More information about the llvm-commits mailing list