[PATCH] D52143: Make initializeOutputStream() return false on error and true on success.

Kristina Brooks via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Sep 16 11:28:40 PDT 2018


kristina added a comment.

My two cents in, false on error makes more sense to me as it's not the same as integer return codes where 0 traditionally indicates success, it makes sense for a verb named function to return false on failure and true on success, or alternatively use a different way of reporting the status back.


https://reviews.llvm.org/D52143





More information about the llvm-commits mailing list