[PATCH] D52143: Make initializeOutputStream() return false on error and true on success.

Erik Pilkington via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Sep 16 12:06:23 PDT 2018

Previous message: [PATCH] D52143: Make initializeOutputStream() return false on error and true on success.
Next message: [lld] r342342 - [ELF] Use llvm::toLower instead of libc call tolower
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

erik.pilkington accepted this revision.
erik.pilkington added a comment.
This revision is now accepted and ready to land.

Okay, if false on error is generally agreed on and used more frequently then LGTM!


https://reviews.llvm.org/D52143

Previous message: [PATCH] D52143: Make initializeOutputStream() return false on error and true on success.
Next message: [lld] r342342 - [ELF] Use llvm::toLower instead of libc call tolower
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

More information about the llvm-commits mailing list