[PATCH] D52143: Make initializeOutputStream() return false on error and true on success.

[Zachary Turner via Phabricator via llvm-commits]

zturner added a subscriber: erik.pilkington.
zturner added a comment.

False on Error os more common and in fact there has been some effort in
llvm to standardize. Several support functions have been changed in the
past because false on success is so confusing. If the function returns an
int (status) or an error that’s a different story, but with a bool false on
error and true on success I think has been generally agreed upon to be what
we should be doing for new code. Not formally in any kind of mailing list
discussion, but it’s come up in several reviews (just that I’ve seen) and
functions have been changed or rewritten to return false on failure


https://reviews.llvm.org/D52143