[PATCH] D50887: [DWARF] Missing location debug information with -O2.

Carlos Alberto Enciso via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 28 01:14:05 PDT 2018


CarlosAlbertoEnciso marked an inline comment as done.
CarlosAlbertoEnciso added a comment.

In https://reviews.llvm.org/D50887#1212565, @aprantl wrote:

> Do you have OrderMap readily available or would you need to compute it first?


At the point where 'collectDebugValues' is called, OrderMap is not available. I need to compute it first.

>> If the goal is to make 'collectDebugValues' more generic, that function should be moved to MachineRegisterInfo and have the steps (1), (2) and (3).
> 
> That doesn't sound like a bad idea.

That would be a good improvement.


https://reviews.llvm.org/D50887





More information about the llvm-commits mailing list