[PATCH] D50495: [DebugInfo] Do not generate duplicated label debug info if it has been processed.

[Adrian Prantl via Phabricator via llvm-commits]

aprantl added inline comments.


================
Comment at: lib/CodeGen/AsmPrinter/CodeViewDebug.cpp:1051
 void CodeViewDebug::collectVariableInfoFromMFTable(
-    DenseSet<InlinedVariable> &Processed) {
+    DenseSet<InlinedEntity> &Processed) {
   const MachineFunction &MF = *Asm->MF;
----------------
HsiangKai wrote:
> aprantl wrote:
> > If this processes only variables, why return a set of InlinedEntities instead of InlinedVariables?
> DILocalVariable and DILabel are both DINode. So, I combined InlinedVariable and InlinedLabel into InlinedEntity.
> In this way, I have no need to allocate two separate ‘Processed’ sets for them. It is cleaner to check them processed or not.
> 
> So, there is no InlinedVariable any more in this patch.
Okay.


Repository:
  rL LLVM

https://reviews.llvm.org/D50495