[PATCH] D50887: [DWARF] Missing location debug information with -O2.

Carlos Alberto Enciso via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 28 01:21:20 PDT 2018


CarlosAlbertoEnciso added a comment.

In https://reviews.llvm.org/D50887#1212594, @vsk wrote:

> @CarlosAlbertoEnciso thanks for investigating this and testing out a new way to collect debug values. Given the complexity of replacing the current algorithm, and that it's not strictly related to fixing MachineCSE, I'd recommend keeping the current algorithm (i.e not using MachineRegisterInfo for now). That will allow us to land a fix in tree soon and hopefully iterate on it.


I think is the best way to proceed right now, as the patch using the current algorithm is quite simple. Once the patch is accepted, I would suggest to explore the replacement of the current algorithm to use MachineRegisterInfo and make 'collectDebugValues' a more general function. It seems that @aprantl like that idea as well.


https://reviews.llvm.org/D50887





More information about the llvm-commits mailing list