[PATCH] D50432: [DAGCombiner] Reduce load widths of shifted masks

[John Brawn via Phabricator via llvm-commits]

john.brawn requested changes to this revision.
john.brawn added inline comments.
This revision now requires changes to proceed.


================
Comment at: lib/CodeGen/SelectionDAG/DAGCombiner.cpp:9232
 
+  if (HasShiftedOffset) {
+    // We're using a shifted mask, so the load now has an offset. This means we
----------------
On big-endian targets ShAmt has been adjusted by the time we get here, in which case the shifts we do here are wrong, e.g. many of the tests you've added are checking that in big-endian the load is eliminated which is not what should be happening.


https://reviews.llvm.org/D50432