[PATCH] D50432: [DAGCombiner] Reduce load widths of shifted masks

[Sam Parker via Phabricator via llvm-commits]

samparker added inline comments.


================
Comment at: lib/CodeGen/SelectionDAG/DAGCombiner.cpp:9232
 
+  if (HasShiftedOffset) {
+    // We're using a shifted mask, so the load now has an offset. This means we
----------------
john.brawn wrote:
> On big-endian targets ShAmt has been adjusted by the time we get here, in which case the shifts we do here are wrong, e.g. many of the tests you've added are checking that in big-endian the load is eliminated which is not what should be happening.
Ah! Thanks, I'm sure BE always trips me up here.


https://reviews.llvm.org/D50432