[PATCH] D50432: [DAGCombiner] Reduce load widths of shifted masks

Sam Parker via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 14 05:13:06 PDT 2018


samparker added inline comments.


================
Comment at: test/CodeGen/ARM/and-load-combine.ll:7
 
-define arm_aapcscc zeroext i1 @cmp_xor8_short_short(i16* nocapture readonly %a,
-                                                    i16* nocapture readonly %b) {
+define arm_aapcscc zeroext i1 @cmp_xor8_short_short(i16* nocapture readonly %a, i16* nocapture readonly %b) {
 ; ARM-LABEL: cmp_xor8_short_short:
----------------
john.brawn wrote:
> It's not clear to me what the purpose of these test changes are (or the previous version). If I revert these changes then the test still pases.
It's just because I've used the update_llc script and the format was different. Moving the arguments onto a single line removed the unnecessary diffs produced by the script.


https://reviews.llvm.org/D50432





More information about the llvm-commits mailing list