[PATCH] D50289: [ELF] Don't copy STT_TLS in copy relocation

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: ELF/Relocations.cpp:468
   for (const Elf_Sym &S : File.getGlobalELFSyms()) {
     if (S.st_shndx == SHN_UNDEF || S.st_shndx == SHN_ABS ||
+        S.getType() == STT_TLS || S.st_value != SS.Value)
----------------
echristo wrote:
> Drive by comment: It'd be great to get a comment about everything in this conditional :)
Agree. I didn't comment them because I still don't understand the stuff enough and feel comfortable to document it :( Hope the conditions are comprehensive now.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D50289